Setting kube-api-qps and kube-api-burst are not working

[kevinteng525]

Report

Sets kube-api-qps and kube-api-burst for KEDA adapter will not take effective.

It was set here

	cfg, err := config.GetConfig()
	if cfg != nil {
		cfg.QPS = adapterClientRequestQPS
		cfg.Burst = adapterClientRequestBurst
		cfg.DisableCompression = disableCompression
	}

However never got used, when new Manager, it will use another config

         mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
		MetricsBindAddress: metricsBindAddress,
		Scheme:             scheme,
		Namespace:          namespace,
		LeaseDuration:      leaseDuration,
		RenewDeadline:      renewDeadline,
		RetryPeriod:        retryPeriod,
	})

Expected Behavior

Setting kube-api-qps and kube-api-burst should be working

Actual Behavior

Setting kube-api-qps and kube-api-burst are not working

Steps to Reproduce the Problem

1. Pass kube-api-qps and kube-api-burst as args, as following

- /usr/local/bin/keda-adapter
        - --secure-port=6443
        - --logtostderr=false
        - --log_file=/tmp/apiserver.log
        - --log_dir=/tmp/log
        - --kube-api-qps=70
        - --kube-api-burst=100

Logs from KEDA operator

N/A

KEDA Version

2.8.1

Kubernetes Version

1.23

Platform

Any

Scaler Details

No response

Anything else?

No response

[v-shenoy]

The main branch code is using the correct config.

keda/main.go

Lines 117 to 122 in af948a5

	cfg := ctrl.GetConfigOrDie()
	cfg.QPS = adapterClientRequestQPS
	cfg.Burst = adapterClientRequestBurst
	cfg.DisableCompression = disableCompression
	mgr, err := ctrl.NewManager(cfg, ctrl.Options{

This feature was added recently, and will be released as part of KEDA v2.9.

[v-shenoy]

The main branch code is using the correct config.

keda/main.go

Lines 117 to 122 in af948a5

	cfg := ctrl.GetConfigOrDie()
	cfg.QPS = adapterClientRequestQPS
	cfg.Burst = adapterClientRequestBurst
	cfg.DisableCompression = disableCompression
	mgr, err := ctrl.NewManager(cfg, ctrl.Options{

This feature was added recently, and will be released as part of KEDA v2.9.

Ah, I am dumb. You're talking about the metrics server, where I can see it's not being used.

keda/adapter/main.go

Line 127 in af948a5

mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{

[zroubalik]

Good catch, thanks for reporting.

[zroubalik]

Relates to #3730

[kevinteng525]

Relates to #3730

Thanks @zroubalik for the fixing! I was also planning to submit a PR for this:)