Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Pipelines Scaler: Improve error logging using poolID #3996

Closed
JorTurFer opened this issue Dec 9, 2022 · 3 comments · Fixed by #4211
Closed

Azure Pipelines Scaler: Improve error logging using poolID #3996

JorTurFer opened this issue Dec 9, 2022 · 3 comments · Fixed by #4211
Assignees
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers needs-discussion

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Dec 9, 2022

Proposal

Currently, in case of any error validating the poolID, the error is hidden:

body, err := getAzurePipelineRequest(ctx, url, metadata, httpClient)
	if err != nil {
		return -1, fmt.Errorf("agent pool with id `%s` not found", poolID)
	}

This makes impossible to troubleshoot the reason behind the fails, we should just return the original error

Use-Case

No response

Anything else?

No response

@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Dec 9, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Dec 9, 2022
@JorTurFer JorTurFer added the good first issue Good for newcomers label Dec 9, 2022
@stale
Copy link

stale bot commented Feb 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Feb 8, 2023
@dttung2905
Copy link
Contributor

Hello @JorTurFer, it should be a quick fix, I could help with this 🙏

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Feb 8, 2023
@JorTurFer
Copy link
Member Author

Thanks a lot!

@github-project-automation github-project-automation bot moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Feb 8, 2023
@JorTurFer JorTurFer moved this from Ready To Ship to Done in Roadmap - KEDA Core Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers needs-discussion
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants