-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEDA metrics api server not honoring log level #5139
Comments
You're right, We will update this when we have more info |
Looking at the code from the Kubernetes library this seems to be expected: https://github.com/kubernetes/utils/blob/3b25d923346b/trace/trace.go#L202-L204 The traces are expected to be written not matter what if the request takes longer than the provided 500 miliseconds threshold: https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/master/pkg/apiserver/endpoints/handlers/get.go#L129 That said I don't think these are critical enough to have with a log level of 0 and I think we should have it for level 4 and higher since it is debug information. We can add a piece of code to custom-metrics-apiserver to do that, but in the meantime I'll revive the discussion in kubernetes/kubernetes#115993 |
Agree with this approach, thanks @dgrisonnet |
Any update on this? |
We had an agreement in kubernetes/kubernetes#115993 to make the traces log level 2. I will try to implement the fix this week. |
Awesome, thanks! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Still and issue. Thanks! |
ping @dgrisonnet ! |
On it. Sorry I didn't follow-up on it after we wrapped up the discussion upstream. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
keep-alive :) |
This issue has been automatically closed due to inactivity. |
I lost track of this one, the PR has been up for a while, I'll try to ping some people on slack to have a look at it kubernetes/utils#301 |
Merged 👍 |
Anybody willing to test this out? :) |
Report
Exact same issue as #3053 and #2316. Trace logs appear in stdout despite running the pod with
-v=0
.The trace logs look like this:
Expected Behavior
Trace logs should not show up when
-v=0
.Actual Behavior
Trace logs show up when
-v=0
.Steps to Reproduce the Problem
-v=0
.Logs from KEDA operator
not relevant
KEDA Version
2.12.0
Kubernetes Version
1.27
Platform
Amazon Web Services
Scaler Details
not relevant
Anything else?
No response
The text was updated successfully, but these errors were encountered: