Change how number of pending messages is calculated and add more error handling. #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmelsayed
reviewed
Jan 7, 2020
|
@balchua it would be great if you can take a look at this PR whenever you get the time :) |
|
@ahmelsayed yup on it. You got that right. Should have used the |
balchua
reviewed
Jan 7, 2020
|
/LGTM thanks @cwoolum |
|
@ahmelsayed the PR LGTM. |
preflightsiren
pushed a commit
to preflightsiren/keda
that referenced
this pull request
Nov 7, 2021
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a change for #520 and adds additional logging to help diagnose connection issues.