Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new common method to parse parameter from config #5228

Merged

Move changelog to others section

aed7512
Select commit
Loading
Failed to load commit list.
Merged

Create a new common method to parse parameter from config #5228

Move changelog to others section
aed7512
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Dec 23, 2023 in 0s

4 / 4 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
The input is always in string, hence the convertStringToType takes in 'raw' value of pameter as string and convert to whatever types we want Incomplete
if its an optional parameter and we can not find from any config, return an empty string Incomplete
if its an optional parameter and is a required parameters, we return a supplied default value Incomplete
I have verified that my change is according to the deprecations & breaking changes policy Completed
Tests have been added ( Missing out tests for convertStringToType method) Completed
Changelog has been updated and is aligned with our changelog requirements Completed
Commits are signed with Developer Certificate of Origin (DCO - learn more) Completed
Add an entry in our changelog in alphabetical order and link related issue Incomplete
Update the documentation, if needed Incomplete
Add unit & e2e tests for your changes Incomplete
GitHub checks are passing Incomplete
Is the DCO check failing? Here is how you can fix DCO issues Incomplete
Our contribution guide Incomplete