Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing TestNamespace to ScaledJob validation test template #5989

Merged
merged 1 commit into from
Jul 29, 2024

Add missing namespace to scaledjob test template

9f3c2d5
Select commit
Loading
Failed to load commit list.
Merged

Add missing TestNamespace to ScaledJob validation test template #5989

Add missing namespace to scaledjob test template
9f3c2d5
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Jul 29, 2024 in 0s

2 / 2 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
It doesn't generally matter for the test -- the test is just checking if the webhook works. It doesn't care where the scaledjob ends up Incomplete
It does matter though if you run this test in a more restrictive environment where you can't write to the default namespace -- it fails with a namespace-related creation error instead of the expected no triggers defined in the ScaledObject/ScaledJob error Incomplete
I have verified that my change is according to the deprecations & breaking changes policy Completed
Commits are signed with Developer Certificate of Origin (DCO - learn more) Completed
View more details on Task list completed