Refactor redis scaler config

[SpiritZhou]

1. Add multi name support in config type
2. Refactor redis scaler config

Provide a description of what has been changed

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to # #5797

[SpiritZhou]

/run-e2e redis
Update: You can check the progress here

[tomkerkhove]

@wozniakjan @dttung2905 mind reviewing?

[dttung2905]

Thank you for the PR. I just have a few minor comments, mostly on the support of multiple key name in our util function

[dttung2905]

Similar question there ? Are you trying to cover all cases where user can mistakenly input a value into the manifest or such cases have been supported in the current code ? 🤔

[wozniakjan]

I think multi-name keys is a good feature, although I wasn't able to find Cert (with capital C) anywhere in the original code. Maybe this is a typo?

[wozniakjan]

lgtm, hopefully multi-named keys won't complicate the API spec generator but we will cross that bridge once we have some tooling foundation.

[rickbrouwer]

@wozniakjan what about the usernameFromEnv and passwordFromEnv? These are mentioned in the documentation as being usable, but are no longer supported via this PR. I also have this problem with the IBM scaler and wanted to see here how it was solved. This issue will also appear by the MySQL scaler. What do you think how to solve this?

[wozniakjan]

what about the usernameFromEnv and passwordFromEnv? These are mentioned in the documentation as being usable, but are no longer supported via this PR.

in this specific PR it should continue to work with usernameFromEnv, unless I'm missing something.

keda/pkg/scalers/redis_scaler.go

Line 50 in 3afc165

Username string `keda:"name=username, order=triggerMetadata;resolvedEnv;authParams"`

this contains order field tag key with value resolvedEnv (among other), and the way it's implemented internally is it appends FromEnv to the name of the parameter and then fetches key from TriggerMetadata map. It works this way because that was the convention in KEDA before #5676 and we didn't want to introduce any breaking changes with this refactor, goal is just to standardize the parsing implementations and reduce code duplication.

keda/pkg/scalers/scalersconfig/typed_config.go

Lines 403 to 405 in 3afc165

	case ResolvedEnv:
	m = sc.ResolvedEnv
	key = sc.TriggerMetadata[fmt.Sprintf("%sFromEnv", key)]

It might be a bit more understandable in this unit test

keda/pkg/scalers/scalersconfig/typed_config_test.go

Lines 27 to 63 in 36cc226

	func TestBasicTypedConfig(t *testing.T) {
	RegisterTestingT(t)
	sc := &ScalerConfig{
	TriggerMetadata: map[string]string{
	"stringVal": "value1",
	"intVal": "1",
	"boolValFromEnv": "boolVal",
	"floatValFromEnv": "floatVal",
	},
	ResolvedEnv: map[string]string{
	"boolVal": "true",
	"floatVal": "1.1",
	},
	AuthParams: map[string]string{
	"auth": "authValue",
	},
	}
	type testStruct struct {
	StringVal string `keda:"name=stringVal, order=triggerMetadata"`
	IntVal int `keda:"name=intVal, order=triggerMetadata"`
	BoolVal bool `keda:"name=boolVal, order=resolvedEnv"`
	FloatVal float64 `keda:"name=floatVal, order=resolvedEnv"`
	AuthVal string `keda:"name=auth, order=authParams"`
	}
	ts := testStruct{}
	err := sc.TypedConfig(&ts)
	Expect(err).To(BeNil())
	Expect(ts.StringVal).To(Equal("value1"))
	Expect(ts.IntVal).To(Equal(1))
	Expect(ts.BoolVal).To(BeTrue())
	Expect(ts.FloatVal).To(Equal(1.1))
	Expect(ts.AuthVal).To(Equal("authValue"))
	}

[rickbrouwer]

@wozniakjan Thanks for the explanation! Then it should work fine for the rest :)

[zroubalik]

/run-e2e redis
Update: You can check the progress here

[SpiritZhou]

/run-e2e redis
Update: You can check the progress here

[SpiritZhou]

@zroubalik Could you help to review it again?

[SpiritZhou]

/run-e2e redis
Update: You can check the progress here