Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor redis scaler config #5997

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Refactor redis scaler config #5997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6ad9cd9
Update
SpiritZhou Jul 30, 2024
fc666bd
Fix
SpiritZhou Jul 30, 2024
56a27db
Merge branch 'main' into spiritzhou/redisrefactor
SpiritZhou Aug 13, 2024
fdfebfa
Update
SpiritZhou Aug 13, 2024
c73441c
Update
SpiritZhou Aug 19, 2024
3afc165
Update
SpiritZhou Aug 19, 2024
51d7498
Merge branch 'main' into spiritzhou/redisrefactor
SpiritZhou Sep 24, 2024
3ee3de4
Update
SpiritZhou Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/scalers/aws_dynamodb_scaler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ type parseDynamoDBMetadataTestData struct {

var (
// ErrAwsDynamoNoTableName is returned when "tableName" is missing from the config.
ErrAwsDynamoNoTableName = errors.New("missing required parameter \"tableName\"")
ErrAwsDynamoNoTableName = errors.New("missing required parameter [\"tableName\"]")

// ErrAwsDynamoNoAwsRegion is returned when "awsRegion" is missing from the config.
ErrAwsDynamoNoAwsRegion = errors.New("missing required parameter \"awsRegion\"")
ErrAwsDynamoNoAwsRegion = errors.New("missing required parameter [\"awsRegion\"]")

// ErrAwsDynamoNoKeyConditionExpression is returned when "keyConditionExpression" is missing from the config.
ErrAwsDynamoNoKeyConditionExpression = errors.New("missing required parameter \"keyConditionExpression\"")
ErrAwsDynamoNoKeyConditionExpression = errors.New("missing required parameter [\"keyConditionExpression\"]")
)

var dynamoTestCases = []parseDynamoDBMetadataTestData{
Expand Down Expand Up @@ -114,7 +114,7 @@ var dynamoTestCases = []parseDynamoDBMetadataTestData{
"targetValue": "no-valid",
},
authParams: map[string]string{},
expectedError: errors.New("error parsing DynamoDb metadata: unable to set param \"targetValue\" value"),
expectedError: errors.New("error parsing DynamoDb metadata: unable to set param [\"targetValue\"] value"),
},
{
name: "invalid activationTargetValue given",
Expand All @@ -128,7 +128,7 @@ var dynamoTestCases = []parseDynamoDBMetadataTestData{
"activationTargetValue": "no-valid",
},
authParams: map[string]string{},
expectedError: errors.New("unable to set param \"activationTargetValue\""),
expectedError: errors.New("unable to set param [\"activationTargetValue\"]"),
},
{
name: "malformed expressionAttributeNames",
Expand Down
Loading
Loading