-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor AWS DynamoDB Streams scaler configuration #6351
Merged
wozniakjan
merged 4 commits into
kedacore:main
from
omerap12:refactor_aws_dynamodb_streams_scaler
Nov 27, 2024
Merged
Refactor AWS DynamoDB Streams scaler configuration #6351
wozniakjan
merged 4 commits into
kedacore:main
from
omerap12:refactor_aws_dynamodb_streams_scaler
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
/run-e2e aws_dynamodb |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Friendly ping :) |
wozniakjan
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
/run-e2e aws_dynamodb |
wozniakjan
reviewed
Nov 26, 2024
JorTurFer
approved these changes
Nov 27, 2024
mpechner-akasa
pushed a commit
to nrichardson-akasa/keda
that referenced
this pull request
Nov 29, 2024
* Refactor AWS DynamoDB Streams scaler configuration Signed-off-by: Omer Aplatony <omerap12@gmail.com> * fixed unit tests Signed-off-by: Omer Aplatony <omerap12@gmail.com> * Fix invalid value test Signed-off-by: Omer Aplatony <omerap12@gmail.com> * go fmt Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com> Signed-off-by: michael pechner <mike.pechner@akasa.com>
robpickerill
pushed a commit
to robpickerill/keda
that referenced
this pull request
Nov 30, 2024
* Refactor AWS DynamoDB Streams scaler configuration Signed-off-by: Omer Aplatony <omerap12@gmail.com> * fixed unit tests Signed-off-by: Omer Aplatony <omerap12@gmail.com> * Fix invalid value test Signed-off-by: Omer Aplatony <omerap12@gmail.com> * go fmt Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Dec 4, 2024
* Refactor AWS DynamoDB Streams scaler configuration Signed-off-by: Omer Aplatony <omerap12@gmail.com> * fixed unit tests Signed-off-by: Omer Aplatony <omerap12@gmail.com> * Fix invalid value test Signed-off-by: Omer Aplatony <omerap12@gmail.com> * go fmt Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Dec 4, 2024
* Refactor AWS DynamoDB Streams scaler configuration Signed-off-by: Omer Aplatony <omerap12@gmail.com> * fixed unit tests Signed-off-by: Omer Aplatony <omerap12@gmail.com> * Fix invalid value test Signed-off-by: Omer Aplatony <omerap12@gmail.com> * go fmt Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Dec 4, 2024
* Refactor AWS DynamoDB Streams scaler configuration Signed-off-by: Omer Aplatony <omerap12@gmail.com> * fixed unit tests Signed-off-by: Omer Aplatony <omerap12@gmail.com> * Fix invalid value test Signed-off-by: Omer Aplatony <omerap12@gmail.com> * go fmt Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>
ctccxxd
pushed a commit
to ctccxxd/keda
that referenced
this pull request
Dec 10, 2024
* Refactor AWS DynamoDB Streams scaler configuration Signed-off-by: Omer Aplatony <omerap12@gmail.com> * fixed unit tests Signed-off-by: Omer Aplatony <omerap12@gmail.com> * Fix invalid value test Signed-off-by: Omer Aplatony <omerap12@gmail.com> * go fmt Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor DynamoDB Streams scaler configuration
Checklist
Relates to #5797