Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AWS DynamoDB Streams scaler configuration #6351

Merged

Conversation

omerap12
Copy link
Contributor

Refactor DynamoDB Streams scaler configuration

Checklist

Relates to #5797

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12 omerap12 requested a review from a team as a code owner November 20, 2024 15:54
@wozniakjan
Copy link
Member

wozniakjan commented Nov 20, 2024

/run-e2e aws_dynamodb
Update: You can check the progress here

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Copy link
Contributor Author

/run-e2e aws_dynamodb Update: You can check the progress here

Friendly ping :)

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan
Copy link
Member

wozniakjan commented Nov 26, 2024

/run-e2e aws_dynamodb
Update: You can check the progress here

@wozniakjan wozniakjan enabled auto-merge (squash) November 27, 2024 09:24
@wozniakjan wozniakjan merged commit 2adbc81 into kedacore:main Nov 27, 2024
20 checks passed
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* fixed unit tests

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* Fix invalid value test

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* go fmt

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

---------

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
robpickerill pushed a commit to robpickerill/keda that referenced this pull request Nov 30, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* fixed unit tests

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* Fix invalid value test

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* go fmt

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

---------

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* fixed unit tests

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* Fix invalid value test

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* go fmt

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

---------

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* fixed unit tests

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* Fix invalid value test

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* go fmt

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

---------

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* fixed unit tests

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* Fix invalid value test

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* go fmt

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

---------

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
ctccxxd pushed a commit to ctccxxd/keda that referenced this pull request Dec 10, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* fixed unit tests

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* Fix invalid value test

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* go fmt

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

---------

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants