-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOSSA license scanning GitHub Action added #860
Conversation
FYI - to have this action work properly, we'll have to add the FOSSA API key as a GitHub secrets variable ( |
@idvoretskyi how can I get FOSSA API key? I can add it to Github secrets. |
@ahmelsayed I hitting an issue when trying to build the tools image today (including the changes from this PR, but they are not relevant), I haven't seen such problem before. By chance do you have an idea what could go wrong? Is there any problem with the microsoft repo?
|
@zroubalik I've tried to build the local image using this Dockerfile, had the same issue, so can confirm. |
Yes, I'm seeing the same issue as well. Looks like a general issue with that keyserver. $ gpg --keyserver packages.microsoft.com --recv-keys BC528686B50D79E339D3721CEB3E94ADBE1229CF
gpg: keyserver receive failed: Connection timed out changing it to the ubuntu keyserver worked. $ gpg --keyserver keyserver.ubuntu.com --recv-keys BC528686B50D79E339D3721CEB3E94ADBE1229CF
gpg: key 0xEB3E94ADBE1229CF: "Microsoft (Release signing) <gpgsecurity@microsoft.com>" not changed
gpg: Total number processed: 1
gpg: unchanged: 1 |
@ahmelsayed thanks, helped. @idvoretskyi the image is updated. |
@zroubalik here we go ^ |
@zroubalik it seems that build fails because of the non-available FOSSA API key. |
I think secrets are not passed to actions run from a fork. |
@ahmelsayed they are not passed from the fork, but we have secrets added to the current repo itself. |
I was referring to this note from github I'm thinking this is what's causing the setting to be empty in the workflow. I see @zroubalik added it 7 hours ago (though I can't see the value) I think if you remove the debug echo we should be able to merge it and see if it passes on master. |
@ahmelsayed good catch, it seems like this could be the problem. |
.github/workflows/fossa.yml
Outdated
run: | | ||
export GOPATH=$HOME/go | ||
export PATH=$PATH:$(go env GOPATH)/bin | ||
echo $FOSSA_API_KEY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the echo is still here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zroubalik done.
author Ihor Dvoretskyi <ihor@linux.com> 1590581755 +0300 committer Ihor Dvoretskyi <ihor@linux.com> 1590742634 +0000 parent 35b2ce8 author Ihor Dvoretskyi <ihor@linux.com> 1590581755 +0300 committer Ihor Dvoretskyi <ihor@linux.com> 1590742532 +0000 FOSSA license scanning GitHub Action added Fixes #808 Signed-off-by: Ihor Dvoretskyi <ihor@linux.com> Debug echo removed Signed-off-by: Ihor Dvoretskyi <ihor@linux.com> Update fossa.yml Typo fix
Fixes #808 Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try!
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
Fixes #808
Signed-off-by: Ihor Dvoretskyi ihor@linux.com