Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOSSA license scanning GitHub Action added #860

Merged
merged 3 commits into from
May 29, 2020
Merged

FOSSA license scanning GitHub Action added #860

merged 3 commits into from
May 29, 2020

Conversation

idvoretskyi
Copy link
Contributor

Fixes #808

Signed-off-by: Ihor Dvoretskyi ihor@linux.com

@idvoretskyi
Copy link
Contributor Author

FYI - to have this action work properly, we'll have to add the FOSSA API key as a GitHub secrets variable (secrets.FOSSA_API_KEY).

@zroubalik
Copy link
Member

@idvoretskyi how can I get FOSSA API key? I can add it to Github secrets.

@zroubalik
Copy link
Member

zroubalik commented May 27, 2020

@ahmelsayed I hitting an issue when trying to build the tools image today (including the changes from this PR, but they are not relevant), I haven't seen such problem before. By chance do you have an idea what could go wrong? Is there any problem with the microsoft repo?

...
Creating config file /etc/apt/apt.conf.d/50unattended-upgrades with new version
Setting up python3-software-properties (0.96.24.32.12) ...
Setting up software-properties-common (0.96.24.32.12) ...
Processing triggers for libc-bin (2.27-3ubuntu1) ...
Processing triggers for dbus (1.12.2-1ubuntu1.1) ...
deb [arch=amd64] https://packages.microsoft.com/repos/azure-cli/ bionic main
Warning: apt-key output should not be parsed (stdout is not a terminal)
Executing: /tmp/apt-key-gpghome.IKSNBCVfqT/gpg.1.sh --keyserver packages.microsoft.com --recv-keys BC528686B50D79E339D3721CEB3E94ADBE1229CF
gpg: keyserver receive failed: Connection timed out
The command '/bin/sh -c apt-get install apt-transport-https lsb-release software-properties-common dirmngr -y &&     AZ_REPO=$(lsb_release -cs) &&     echo "deb [arch=amd64] https://packages.microsoft.com/repos/azure-cli/ $AZ_REPO main" |         tee /etc/apt/sources.list.d/azure-cli.list &&     apt-key --keyring /etc/apt/trusted.gpg.d/Microsoft.gpg adv         --keyserver packages.microsoft.com         --recv-keys BC528686B50D79E339D3721CEB3E94ADBE1229CF &&     apt-get update &&     apt-get install -y azure-cli' returned a non-zero code: 2

@idvoretskyi
Copy link
Contributor Author

@zroubalik I've tried to build the local image using this Dockerfile, had the same issue, so can confirm.

@ahmelsayed
Copy link
Contributor

Yes, I'm seeing the same issue as well. Looks like a general issue with that keyserver.

$ gpg  --keyserver packages.microsoft.com --recv-keys BC528686B50D79E339D3721CEB3E94ADBE1229CF
gpg: keyserver receive failed: Connection timed out

changing it to the ubuntu keyserver worked.

$ gpg  --keyserver keyserver.ubuntu.com --recv-keys BC528686B50D79E339D3721CEB3E94ADBE1229CF
gpg: key 0xEB3E94ADBE1229CF: "Microsoft (Release signing) <gpgsecurity@microsoft.com>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1

#861

@zroubalik
Copy link
Member

zroubalik commented May 28, 2020

Yes, I'm seeing the same issue as well. Looks like a general issue with that keyserver.

$ gpg  --keyserver packages.microsoft.com --recv-keys BC528686B50D79E339D3721CEB3E94ADBE1229CF
gpg: keyserver receive failed: Connection timed out

changing it to the ubuntu keyserver worked.

$ gpg  --keyserver keyserver.ubuntu.com --recv-keys BC528686B50D79E339D3721CEB3E94ADBE1229CF
gpg: key 0xEB3E94ADBE1229CF: "Microsoft (Release signing) <gpgsecurity@microsoft.com>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1

#861

@ahmelsayed thanks, helped.

@idvoretskyi the image is updated.

@idvoretskyi
Copy link
Contributor Author

@zroubalik here we go ^

@idvoretskyi
Copy link
Contributor Author

@zroubalik it seems that build fails because of the non-available FOSSA API key.

@ahmelsayed
Copy link
Contributor

I think secrets are not passed to actions run from a fork.

@idvoretskyi
Copy link
Contributor Author

@ahmelsayed they are not passed from the fork, but we have secrets added to the current repo itself.

@ahmelsayed
Copy link
Contributor

I was referring to this note from github

image

I'm thinking this is what's causing the setting to be empty in the workflow. I see @zroubalik added it 7 hours ago (though I can't see the value)

I think if you remove the debug echo we should be able to merge it and see if it passes on master.

@zroubalik
Copy link
Member

@ahmelsayed good catch, it seems like this could be the problem.

run: |
export GOPATH=$HOME/go
export PATH=$PATH:$(go env GOPATH)/bin
echo $FOSSA_API_KEY
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the echo is still here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zroubalik done.

author Ihor Dvoretskyi <ihor@linux.com> 1590581755 +0300
committer Ihor Dvoretskyi <ihor@linux.com> 1590742634 +0000

parent 35b2ce8
author Ihor Dvoretskyi <ihor@linux.com> 1590581755 +0300
committer Ihor Dvoretskyi <ihor@linux.com> 1590742532 +0000

FOSSA license scanning GitHub Action added

Fixes #808

Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>

Debug echo removed

Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>

Update fossa.yml

Typo fix
Fixes #808

Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try!

@zroubalik zroubalik merged commit 3f2cd59 into kedacore:master May 29, 2020
@idvoretskyi idvoretskyi deleted the patch-1 branch May 29, 2020 14:15
tbickford pushed a commit to tbickford/keda that referenced this pull request Jun 21, 2020
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy FOSSA license scanning
3 participants