Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(datasets): blacken code in rst literal blocks #365

Closed
deepyaman opened this issue Oct 2, 2023 · 3 comments · Fixed by #362
Closed

docs(datasets): blacken code in rst literal blocks #365

deepyaman opened this issue Oct 2, 2023 · 3 comments · Fixed by #362
Assignees

Comments

@deepyaman
Copy link
Member

deepyaman commented Oct 2, 2023

Description

Basically, auto-format the code in docstrings.

Context

Because it bothers me, because I'm me. Also, helps catch silly issues for kedro-org/kedro#2287 (since at least it validates the AST).

Possible Implementation

#362 (currently for one dateset, but it just needs to be extended by marking the rest of these as explicit pycon blocks)

Possible Alternatives

@astrojuanlu
Copy link
Member

If this is for kedro-datasets, should we transfer this issue?

@deepyaman
Copy link
Member Author

deepyaman commented Oct 2, 2023

If this is for kedro-datasets, should we transfer this issue?

I added it here, so it can be added to the sprint board (needs to be in the main repo for that, right?).

If not, both this and #366 can be in kedro-plugins, yes.

@stichbury stichbury transferred this issue from kedro-org/kedro Oct 3, 2023
@stichbury
Copy link
Contributor

If this is for kedro-datasets, should we transfer this issue?

I added it here, so it can be added to the sprint board (needs to be in the main repo for that, right?).

You can have something in a different repo and put it in the project (right hand sidebar) so it appears on the board. So I've moved this and #366

@deepyaman deepyaman moved this from To Do to In Review in Kedro Framework Oct 6, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants