Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kedro-telemetry to use the CI environment variable to indicate that data comes from a CI environment #483

Closed
Tracked by #1640
noklam opened this issue Jul 31, 2023 · 4 comments · Fixed by #565
Assignees

Comments

@noklam
Copy link
Contributor

noklam commented Jul 31, 2023

Description

Use the CI environment variable to differentiate runs between a CI/CD environment and a real kedro project run for data collection.

kedro-org/kedro#1640 (comment)

I think it would be good to take this opportunity to distinguish CI runs in telemetry. Maybe can read an environment variable; most CI systems (GitHub Actions, CircleCI, Travis CI, etc.) follow the convention of setting CI=true, so I would recommend detecting presence of the environment variable, solving the telemetry prompt automatically, and recording commands as belonging to a CI run--and ideally not requiring any additional configuration or hacks to avoid this telemetry prompt.

Whoever pick up this ticket should double check if CI is a standard convention we can use. Alternatively, we can refer to how Dagester do it:
https://github.com/dagster-io/dagster/blob/e31e577b8841e0ff54745e206d621d9bf934a063/python_modules/dagster/dagster/_core/telemetry.py#L92

@datajoely
Copy link
Contributor

I still think this should be CLI command as well

@noklam
Copy link
Contributor Author

noklam commented Jul 31, 2023

@astrojuanlu
Copy link
Member

This is about reporting that Kedro is being run from a CI environment.

@astrojuanlu
Copy link
Member

Example: How Dagster does it: https://github.com/dagster-io/dagster/blob/e31e577b8841e0ff54745e206d621d9bf934a063/python_modules/dagster/dagster/_core/telemetry.py#L92-L101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants