Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine demotion process of dataset contributions #582

Closed
merelcht opened this issue Feb 28, 2024 · 5 comments
Closed

Determine demotion process of dataset contributions #582

merelcht opened this issue Feb 28, 2024 · 5 comments
Assignees

Comments

@merelcht
Copy link
Member

Description

Datasets within the regular kedro_datasets contributions folder may deterioriate and get outdated over time. We might then need to decide to demote these datasets back to the experimental contributions space.

We need to establish clear criteria and guidelines for determining when a regular contribution needs to be demoted.

Task

@merelcht
Copy link
Member Author

My suggestion for demoting datasets is as follows:

Demotion process of datasets

We should consider demoting a dataset from a “regular” contribution back to the experimental contribution space when:

  • The quality of the dataset no longer meets the standards of a regular dataset contribution and is not fixable:
    • Dependencies no longer supported/maintained
    • Doesn’t work on all supported Python versions
    • Doesn’t work on Windows and/or Linux anymore

The Kedro team should consider regular datasets as our responsibility just as the majority of the Kedro codebase, and demoting a dataset shouldn't be done lightly as it basically means discontinuing formal support.

@merelcht merelcht moved this from In Progress to In Review in Kedro Framework Mar 11, 2024
@yetudada
Copy link
Contributor

It's brilliant that you're thinking of this!

@deepyaman
Copy link
Member

Just throwing it out there—is it possible primary maintainer leaves, and there isn't anybody on the TSC who wants to commit to maintaining it? Or we just force it upon somebody/collective responsibility at that point? :)

@ElenaKhaustova
Copy link
Contributor

I wonder what the order of steps should be. So, for example, we can mark those datasets as candidates for moving to "experimental" in release X.X.X and give some time for contributors to update and move them in case no changes were made. Alternatively, we can move those datasets in the following release and expect them to follow "graduation rules" to be moved back to "regular".

@merelcht
Copy link
Member Author

merelcht commented Apr 4, 2024

Closing this in favour of continuing the discussion in #583

Bottom line is that the following make up the demotion process:

  1. The demotion process will be triggered by someone from the TSC when a dataset isn’t deemed fit as a regular contribution anymore.
  2. We need 1/2 approval from the TSC to initiate a review/merge to the experimental datasets space.

@merelcht merelcht closed this as completed Apr 4, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants