Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI on kedro-sphinx-theme #10

Closed
astrojuanlu opened this issue Jun 27, 2024 · 2 comments
Closed

Fix CI on kedro-sphinx-theme #10

astrojuanlu opened this issue Jun 27, 2024 · 2 comments
Assignees

Comments

@astrojuanlu
Copy link
Member

@rashidakanchwala rashidakanchwala changed the title Fix CI Fix CI on kedro-sphinx-thene Sep 9, 2024
@rashidakanchwala rashidakanchwala changed the title Fix CI on kedro-sphinx-thene Fix CI on kedro-sphinx-theme Sep 9, 2024
@astrojuanlu
Copy link
Member Author

astrojuanlu commented Sep 30, 2024

After a bit of exploration by @Huongg it wasn't clear what to test from a Sphinx theme. Some high-profile themes don't have any tests at all...

@Huongg can we add a simple smoke test that verifies that the contents of the binary build artifact?

In other words: uv build produces 2 files, one sdist in .tar.gz format and one binary wheel in .whl format (they get uploaded to PyPI with uv publish). The smoke test should check that the contents of the .whl include

  • An /assets/ folder with >=1 CSS and JS files,
  • A /theme/kedro-sphinx-theme/ folder with >=1 HTML files, and
  • A /theme/kedro-sphinx-theme/theme.conf file

?

(Note that .whl files are Zip files, you can do unzip path.whl or open them with the zipfile module)

@astrojuanlu
Copy link
Member Author

Fixed by #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants