-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering of pipelines on Kedro-Viz flowchart in VSCode #2269
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jitendra Gundaniya <38945204+jitu5@users.noreply.github.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
I'm not sure how to QA this. Here's what I tried:
I still see the old UI for some reason. |
@astrojuanlu This step is only needed when there are changes in the Kedro-Viz backend. However, in this PR, we are making changes to the frontend. Therefore, we need an npm-published version of Kedro-Viz that includes our changes to use in the extension. I have published a test npm package to test these changes in the extension: Instead of step 3 |
Thanks 🙏🏼 Can't get to this today or tomorrow, if it's not merged yet by Monday I'll review it. |
Description
Resolves kedro-org/vscode-kedro#157
The pull request introduces a feature to filter pipelines within the Kedro-Viz flowchart when using Visual Studio Code (VSCode). This enhancement allows users to selectively view and manage specific pipelines directly in the VSCode environment, improving navigation and focus during development.
Development notes
Key changes include:
SHOW_PIPELINE_FILTER
action andtogglePipelineFilter
function insrc/actions/index.js
to manage the pipeline filter toggle state.src/store/middleware.js
to handle the newSHOW_PIPELINE_FILTER
action.src/components/app/app.js
to load pipeline data when the selected pipeline changes.togglePipelineFilter
tosrc/components/flowchart-primary-toolbar/flowchart-primary-toolbar.js
and included a newFilterIcon
button.FilterIcon
component insrc/components/icons/filter.js
for the filter button.PrimaryToolbar
insrc/components/primary-toolbar/primary-toolbar.js
to display the filter button based on thedisplay
prop.filterBtn
tofalse
insrc/store/initial-state.js
.QA notes
KedroViz
component passdisplay.filterBtn
astrue
GIF
Checklist
RELEASE.md
file