Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-1647] Refactor random data generator, and add layers #161

Merged
merged 11 commits into from
May 11, 2020

Conversation

richardwestenra
Copy link
Contributor

Description

  1. I realised some ways that the random data generator creates nodes/edges could be improved and simplified.
  2. I needed to add layers to the random data generator

Development notes

The random data generator now assigns layers in a way that make the ranks towards the top have more nodes than the ones at the bottom, which is more in line with how charts should behave in reality.

I've also randomly assigned the number of ranks per layer, so that they will grow and shrink each time.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@richardwestenra richardwestenra merged commit 43b3d8d into develop May 11, 2020
@richardwestenra richardwestenra deleted the feature/random-layers branch May 11, 2020 11:33
@richardwestenra richardwestenra mentioned this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants