Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to transition layer height on zoom #166

Merged
merged 2 commits into from
May 19, 2020

Conversation

richardwestenra
Copy link
Contributor

Description

Modifying DOM attributes is expensive. Transitioning height is also expensive. This PR removes a CSS height transition and a DOM update, because the height isn't strictly necessary for this effect. Now the label is centred, the gradient is on the container, and the translation is the only thing that gets animated, which should help performance a little.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

As the variable is not defined in this file
@richardwestenra richardwestenra merged commit b15146a into develop May 19, 2020
@richardwestenra richardwestenra deleted the fix/layer-performance branch May 19, 2020 15:11
@richardwestenra richardwestenra mentioned this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants