Fix e2e tests #172
Merged
Fix e2e tests #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardwestenra
approved these changes
May 21, 2020
limdauto
approved these changes
May 21, 2020
Potentially. I'm not sure what's happening, it's failing locally for me and @DmitriiDeriabinQB . |
6 tasks
andrii-ivaniuk
approved these changes
May 21, 2020
…quirements before so it should work without it for old versions
lorenabalan
changed the title
mzjp2
approved these changes
May 21, 2020
| res = run( | ||
| [context.kedro, "new", "-c", str(context.config_file)], | ||
| env=context.env, | ||
| cwd=str(context.temp_dir) |
There was a problem hiding this comment.
I guess we don’t technically need this change, but it can’t hurt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last scenario in
viz.featurefails, which I was able to reproduce manually in a clean environment. It is actually expected behaviour, we should update our tests.Development notes
We don't run
kedro installafter creating a Kedro project in e2e tests, which is an incomplete workflow.QA notes
Somehow this failed on my machine with a weird error (https://stackoverflow.com/questions/54093020/no-module-named-pandas-libs-tslib/54539768) complaining about
pandasalready being installed, so checking if this is reproduced on CI. If yes, it's sth weird we're doing in behave setup.Checklist
RELEASE.mdfileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.