Add support for Python 3.8 #173
Merged
+28
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
921kiyo
requested review from
DmitriiDeriabinQB,
richardwestenra and
yetudada
as code owners
921kiyo
commented
May 22, 2020
| @@ -96,7 +104,7 @@ def call(cmd, verbose=False): | |||
| context.temp_dir = Path(tempfile.mkdtemp()) | |||
|
|
|||
|
|
|||
| def after_scenario(context, feature): | |||
There was a problem hiding this comment.
feature arg was never used, so I removed it.
|
We need to pin |
No, I don't think so. Earlier versions of Kedro won't install anyways if you're running Python 3.8. |
mzjp2
approved these changes
May 22, 2020
limdauto
approved these changes
May 26, 2020
There was a problem hiding this comment.
LGTM! Although @DmitriiDeriabinQB suggested that maybe we should consider dropping pre-15 version of Kedro.
DmitriiDeriabinQB
approved these changes
May 26, 2020
| import tempfile | ||
| from pathlib import Path | ||
|
|
||
| from features.steps.sh_run import run | ||
| from features.steps.util import create_new_venv | ||
|
|
||
|
|
||
| def before_scenario(context, feature): # pylint: disable=unused-argument | ||
| def _should_exclude_scenario(scenario): |
Yeah, I think that's the plan for the next release ( |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kedro 0.16.* has been released, which supports Python 3.8. So we are also supporting Python 3.8 for Kedro-Viz plugins.
Development notes
Modified the e2e tests
Checklist
RELEASE.mdfileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.