-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.8 #173
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5b09817
Add python 3.8
921kiyo 5f3addf
Update setup.py
921kiyo efc28fd
Skip some scenario in e2e
921kiyo 6dcaeb2
Add new scenario
921kiyo 7228acf
Merge branch 'develop' into feature/python3.8
921kiyo 0562c23
Update before_scenario
921kiyo 56e7317
remove feature
921kiyo 2080746
Update logic
921kiyo 6f7a123
Update sys.version_info
921kiyo 0db19f3
Kedro install
921kiyo 30fdedb
Make helper func private
921kiyo 741c1e0
Update release note
921kiyo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,17 +32,25 @@ | |
import os | ||
import shutil | ||
import stat | ||
import sys | ||
import tempfile | ||
from pathlib import Path | ||
|
||
from features.steps.sh_run import run | ||
from features.steps.util import create_new_venv | ||
|
||
|
||
def before_scenario(context, feature): # pylint: disable=unused-argument | ||
def _should_exclude_scenario(scenario): | ||
pre_16_scenario = any(key in scenario.name for key in ["0.14", "0.15"]) | ||
return sys.version_info >= (3, 8) and pre_16_scenario | ||
|
||
|
||
def before_scenario(context, scenario): # pylint: disable=unused-argument | ||
"""Environment preparation before other cli tests are run. | ||
Installs kedro by running pip in the top level directory. | ||
""" | ||
if _should_exclude_scenario(scenario): | ||
scenario.skip() | ||
|
||
def call(cmd, verbose=False): | ||
res = run(cmd, env=context.env) | ||
|
@@ -96,7 +104,7 @@ def call(cmd, verbose=False): | |
context.temp_dir = Path(tempfile.mkdtemp()) | ||
|
||
|
||
def after_scenario(context, feature): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
def after_scenario(context, scenario): | ||
# pylint: disable=unused-argument | ||
rmtree(str(context.temp_dir)) | ||
if "E2E_VENV" not in os.environ: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍