Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User research to see if we should remove the file-based logging handlers #1472

Closed
Tracked by #1461
antonymilne opened this issue Apr 22, 2022 · 1 comment
Closed
Tracked by #1461
Assignees

Comments

@antonymilne
Copy link
Contributor

antonymilne commented Apr 22, 2022

Currently kedro logs to info.log and error.log files by default as well as to the console. Do some sort of user poll to find out how many people use the info.log and error.log files or whether we should just log to the console.

For context, see @noklam's comment here and following discussion: #1461 (comment).

@antonymilne antonymilne changed the title Remove the file-based logging handlers by default. also needed for databricks? do a poll User research to see if we should remove the file-based logging handlers Apr 22, 2022
@antonymilne antonymilne moved this to Todo in Kedro Framework Apr 22, 2022
@antonymilne antonymilne changed the title User research to see if we should remove the file-based logging handlers User research + implement removing the file-based logging handlers Apr 22, 2022
@antonymilne antonymilne changed the title User research + implement removing the file-based logging handlers User research to see if we should remove the file-based logging handlers Apr 22, 2022
@merelcht merelcht added this to the Improve logging setup milestone Apr 25, 2022
@antonymilne antonymilne moved this from Todo to In Progress in Kedro Framework May 9, 2022
@merelcht merelcht moved this from In Progress to Todo in Kedro Framework May 9, 2022
@antonymilne antonymilne self-assigned this May 12, 2022
@antonymilne antonymilne moved this from Todo to In Progress in Kedro Framework May 12, 2022
@antonymilne
Copy link
Contributor Author

The results are in!
image

image

And some comments:

I use info.log to log verbose information regarding the execution of an algorithm that I run in a node. If the output of the algorithm shows unexpected results, I can look in info.log to see what could have caused this unexpected result.

I use the logs in the directory mainly when running inside the docker container created with the kedro-docker plugin.
When developing I mostly look at the console output even though it's useful to have a running history of previous executions even when developing

Conclusion

People do use the logs files. Let's leave them there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants