Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make behaviour with OmegaConfLoader for kedro ipython consistent with "regular" CLI flow #2255

Closed
merelcht opened this issue Jan 24, 2023 · 1 comment

Comments

@merelcht
Copy link
Member

merelcht commented Jan 24, 2023

Description

When using the OmegaConfLoader with kedro ipython it behaves differently from running it through the CLI e.g. kedro run

Differences:

  1. kedro ipython fails to start up while trying to load logging.yml this is a similar error that was solved in Only convert omegaconf DictConfig to primitive type for logging #2176 but because the flow is different for the ipython startup this needs to be fixed in another way
  2. kedro ipython fails to start up when you have empty parameters files
  3. You get different errors when trying to use environment variables in the catalog or parameter files. When executing kedro run you correctly get an error about oc.env not being supported, but when going through the ipython workflow it parses the environment variables correctly and would only fail if that value doesn't fit the catalog entry/parameter. (e.g. passing a AWS key as file path in the catalog)
@merelcht
Copy link
Member Author

I couldn't figure out what was going on... created a new project.. nothing wrong 🤦‍♀️ Glad I found after starting at this for 1 day instead of more 😅

@github-project-automation github-project-automation bot moved this from In Progress to Done in Kedro Framework Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant