Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node to dataset hooks #2271

Closed
antonymilne opened this issue Feb 1, 2023 · 0 comments · Fixed by #2296
Closed

Add node to dataset hooks #2271

antonymilne opened this issue Feb 1, 2023 · 0 comments · Fixed by #2296
Assignees
@noklam
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@antonymilne
Copy link
Contributor

Following #2258 and tech design discussion, we're going ahead with adding node to the dataset hooks.

This should be straightforward:

  • all four dataset hook specifications should be updated to include node: Node as an argument
  • all hook calls (in both _run_node_sequential and _run_node_async) need to be modified to include node
  • update tests
@antonymilne antonymilne added the Issue: Feature Request New feature or improvement to existing feature label Feb 1, 2023
@antonymilne antonymilne mentioned this issue Feb 1, 2023
Closed
@antonymilne antonymilne moved this to To Do in Kedro Framework Feb 1, 2023
@noklam noklam moved this from To Do to In Progress in Kedro Framework Feb 7, 2023
@noklam noklam self-assigned this Feb 7, 2023
@noklam noklam mentioned this issue Feb 7, 2023
Merged
5 tasks
@noklam noklam linked a pull request Feb 8, 2023 that will close this issue
Add node as an argument to all datasets' hook #2296
Merged
5 tasks
@noklam noklam moved this from In Progress to In Review in Kedro Framework Feb 8, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noklam noklam

Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
Kedro Framework
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add node as an argument to all datasets' hook kedro-org/kedro
2 participants
@noklam @antonymilne