-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cookiecutter hooks to strip-out not selected "add-ons" from base template #2837
Comments
I had some thoughts on some approaches we could take for this issue which is being done in #2987. Specifically to handle the dependencies in Approach A (Reactive): Start with a requirements.txt and pyproject.toml that includes dependencies for all add-ons by default as we do now. Adv:
Cons:
Approach B (Proactive): Start with a barebones Adv:
Cons:
Which approach do you think is more better for our needs? I am inclined to Approach B but also open to hear everyone's thoughts or opinions. @merelcht @lrcouto @noklam @astrojuanlu @amandakys PS, maybe an even more radical idea we have separate dependency files for each add-on: e.g., PPS, This opens up to a larger question what should the default add-ons case be, in #2987, I've set it to none, no add-ons included, but it this the right way? |
I'm also in favour of approach B as it's the most adaptable if we want to allow users to add plugins later in their project journey and not only in the project creation flow.
IMO, that is indeed the right way. Since we're calling this the "add-ons" flow to me it makes the most sense that you start with nothing and add on what you need, so that means a default of none. |
Closed by #2987 |
Description
Follow up on #2758
Context
Depending on the utilities/add-ons a user selects from the following:
We need to add in certain directories/files in a new project when the user executes
kedro new
without starter.Proposed Implementation
Use cookiecutter hooks to remove and update files/directories depending on the add-ons selection: https://cookiecutter.readthedocs.io/en/stable/advanced/hooks.html#example-conditional-files-directories
/tests
and updaterequirements.txt
andpyproject.toml
if testing is not selectedsetup.cfg
(might already be gone by the time this ticket is taken up) and updaterequirements.txt
andpyproject.toml
if linting is not selectedlogging.yml
if logging is not selected/data
if data structure is not selected/docs
and updatesetup.py
if documentation is not selectedThe text was updated successfully, but these errors were encountered: