Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin fsspec in test requirements #3102

Closed
ankatiyar opened this issue Oct 2, 2023 · 0 comments · Fixed by #3481
Closed

Unpin fsspec in test requirements #3102

ankatiyar opened this issue Oct 2, 2023 · 0 comments · Fixed by #3481
Assignees
@merelcht
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@ankatiyar
Copy link
Contributor

ankatiyar commented Oct 2, 2023 •
edited
Loading

Description

In the migration of test requirements from setup.py to pyproject.toml (See #3078), the version of fsspec was pinned to <2023.9 in the test requirements. (on the develop branch)

The latest versions of fsspec are causing the test "test_no_versions_with_cloud_protocol" in tests/io/test_data_catalog.py to fail.

This is a follow up ticket to investigate the test failure and remove the fsspec pin from the test requirements.
@ankatiyar ankatiyar added the Issue: Feature Request New feature or improvement to existing feature label Oct 2, 2023
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@merelcht merelcht moved this to To Do in Kedro Framework Nov 27, 2023
@merelcht merelcht moved this from To Do to In Progress in Kedro Framework Jan 4, 2024
@merelcht merelcht self-assigned this Jan 4, 2024
@merelcht merelcht mentioned this issue Jan 4, 2024
Merged
7 tasks
@merelcht merelcht moved this from In Progress to In Review in Kedro Framework Jan 4, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merelcht merelcht

Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
Kedro Framework
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unpin fsspec kedro-org/kedro
2 participants
@merelcht @ankatiyar