Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in kedro new add-ons flows #3185

Closed
noklam opened this issue Oct 17, 2023 · 4 comments · Fixed by #3263
Closed

Bug in kedro new add-ons flows #3185

noklam opened this issue Oct 17, 2023 · 4 comments · Fixed by #3263
Assignees
@noklam @AhdraMeraliQB
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed
Milestone
Project creation ...

Comments

@noklam
Copy link
Contributor

noklam commented Oct 17, 2023 •
edited
Loading

Description

This is in develop branch only.

See
image

I try two different CLI and the result is unexpected.

  1. kedro new, then 1,33
  2. kedro new, then 1, 6

Both are invalid options, the first one fail immediately but the second didn't. I believe the 1. is the correct behavior. Cc @amandakys Can you confirm this?
@noklam
Copy link
Contributor Author

noklam commented Oct 17, 2023

Noted I have a space in the screenshot with 1, 33, I try again and it fails without space.
image

@noklam noklam added the Issue: Bug Report 🐞 Bug that needs to be fixed label Oct 17, 2023
@noklam noklam self-assigned this Oct 17, 2023
@merelcht
Copy link
Member

Great catch! I have been able to replicate this behaviour. I think it's as soon as you add a double digit choice, so anything above 10.

@merelcht merelcht moved this to To Do in Kedro Framework Oct 25, 2023
@AhdraMeraliQB
Copy link
Contributor

This issue has been extended to include extending the flexibility of the case and whitespace sensitivity

@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@merelcht merelcht moved this from To Do to In Progress in Kedro Framework Nov 1, 2023
@AhdraMeraliQB AhdraMeraliQB mentioned this issue Nov 2, 2023
Merged
7 tasks
@AhdraMeraliQB AhdraMeraliQB linked a pull request Nov 2, 2023 that will close this issue
Adjust add-on input validation #3263
Merged
7 tasks
@AhdraMeraliQB AhdraMeraliQB moved this from In Progress to In Review in Kedro Framework Nov 2, 2023
@merelcht
Copy link
Member

merelcht commented Nov 9, 2023

Fixed in #3263

@merelcht merelcht closed this as completed Nov 9, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noklam noklam

@AhdraMeraliQB AhdraMeraliQB

Labels
Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
Kedro Framework
Archived in project
Milestone
Project creation wizard i.e. utility ...
Development

Successfully merging a pull request may close this issue.

Adjust add-on input validation kedro-org/kedro
3 participants
@noklam @merelcht @AhdraMeraliQB