Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos under a note section in https://docs.kedro.org/en/stable/data/data_catalog.html #3217

Closed
iamhassaan opened this issue Oct 24, 2023 · 6 comments
Labels
Community Issue/PR opened by the open-source community Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Bug Report 🐞 Bug that needs to be fixed

Comments

@iamhassaan
Copy link

In Kedro stable documentation under data-catalog.

There is a [note](https://docs.kedro.org/en/stable/data/data_catalog.html#:~:text=Note%20that%20HTTP(S)%20is%20a%20supported%20file%20system%20in%20the%20dataset%20implementations%2C%20but%20if%20you%20it%2C%20you%20can%E2%80%99t%20also%20use%20versioning.) with ambiguous context.

It says:

"Note that HTTP(S) is a supported file system in the dataset implementations, but if you it, you can’t also use versioning."

It should be changed to:

"Note that HTTP(S) is a supported file system in the dataset implementations, but if you use it, you can’t also use versioning."

@astrojuanlu
Copy link
Member

Hi @iamhassaan , thanks for reporting! Do you want to fix this typo yourself? Feel free to submit a pull request.

@astrojuanlu astrojuanlu added Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Bug Report 🐞 Bug that needs to be fixed Community Issue/PR opened by the open-source community Hacktoberfest labels Oct 24, 2023
@astrojuanlu astrojuanlu changed the title Typos under a note section in "https://docs.kedro.org/en/stable/data/data_catalog.html" Typos under a note section in https://docs.kedro.org/en/stable/data/data_catalog.html Oct 24, 2023
@miikkuu
Copy link

miikkuu commented Oct 24, 2023

please assign me!

@astrojuanlu
Copy link
Member

Hi @miikkuu , no need to assign the issue - whoever sends the PR first and is more responsive to maintainer feedback will get it merged!

@JayOaks
Copy link
Contributor

JayOaks commented Oct 30, 2023

Hello,
Please I would like to submit a PR for this.

@astrojuanlu
Copy link
Member

Hi @JayOaks, go ahead!

@JayOaks JayOaks mentioned this issue Oct 30, 2023
7 tasks
@merelcht
Copy link
Member

Closed in #3239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Issue/PR opened by the open-source community Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
Archived in project
Development

No branches or pull requests

5 participants