You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the catalog we have a method called add_feed_dict. Which is arguably one of the worst named methods in the public API. Unfortunately, renaming it is a breaking change. For 0.20.0 we should totally rename it, but in the mean time we should add a better docstring explanation so that engineers working on this code can better understand what it does.
Context
This method was added a long time ago, likely even before Kedro was called Kedro, which git blame doesn't even know about. It was added before the catalog could be loaded from yaml and is supposed to describe how data can be "fed" into the catalog dictionary. The term "feed_dict" might come from clojure or tensorflow lingo, nobody really remembers 🤷
The text was updated successfully, but these errors were encountered:
Description
In the catalog we have a method called
add_feed_dict
. Which is arguably one of the worst named methods in the public API. Unfortunately, renaming it is a breaking change. For0.20.0
we should totally rename it, but in the mean time we should add a better docstring explanation so that engineers working on this code can better understand what it does.Context
This method was added a long time ago, likely even before Kedro was called Kedro, which git blame doesn't even know about. It was added before the catalog could be loaded from
yaml
and is supposed to describe how data can be "fed" into the catalog dictionary. The term "feed_dict" might come from clojure or tensorflow lingo, nobody really remembers 🤷The text was updated successfully, but these errors were encountered: