Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about tag names convention/limitation #3727

Closed
Lasica opened this issue Mar 20, 2024 · 3 comments · Fixed by #3785
Closed

Add info about tag names convention/limitation #3727

Lasica opened this issue Mar 20, 2024 · 3 comments · Fixed by #3785
Labels
Community Issue/PR opened by the open-source community Component: Documentation 📄 Issue/PR for markdown and API documentation good first issue Good first issues for beginners

Comments

@Lasica
Copy link

Lasica commented Mar 20, 2024

Description

Add info about this part of code

if name and not re.match(r"[\w\.-]+$", name):
raise ValueError(
f"'{name}' is not a valid node name. It must contain only "
f"letters, digits, hyphens, underscores and/or fullstops."

Documentation page (if applicable)

https://docs.kedro.org/en/stable/api/kedro.pipeline.node.html - implies any string is fine
https://docs.kedro.org/en/stable/nodes_and_pipelines/nodes.html#how-to-tag-a-node - info box here

Context

Slack conversation:
https://linen-slack.kedro.org/t/16720002/are-there-any-special-characters-that-should-be-avoided-in-t#591ec378-8ea7-4fd2-9f80-c7fefea3d1aa

@noklam noklam added the Component: Documentation 📄 Issue/PR for markdown and API documentation label Mar 20, 2024
@noklam
Copy link
Contributor

noklam commented Mar 25, 2024

@Lasica Would you be interested to open a PR to fix it? We are happy to take PR for this.

@noklam noklam added the good first issue Good first issues for beginners label Mar 25, 2024
@boringbyte
Copy link
Contributor

boringbyte commented Apr 5, 2024

@Lasica I would like to contribute. I can create fix it and open PR.

@astrojuanlu
Copy link
Member

@boringbyte go ahead!

@boringbyte boringbyte mentioned this issue Apr 7, 2024
7 tasks
@noklam noklam added the Community Issue/PR opened by the open-source community label Apr 8, 2024
@merelcht merelcht linked a pull request May 21, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Issue/PR opened by the open-source community Component: Documentation 📄 Issue/PR for markdown and API documentation good first issue Good first issues for beginners
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants