-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Pluggy depdendency version (<1.4) - Preventing upgrade of Pytest 8.1 that requires pluggy >=1.4 #3763
Comments
Created a draft PR to see what breaks pluggy. Curious if there is any goodies for pytest 8.0? We are still on <8.0. |
Just to add another data point here. I was also tripped up by this when running vizro tests which use pytest and have kedro as a dependency. |
@antonymilne the dependency is removed already. I think we may have accidentally pin pytest as core dependencies in some version, it should be test dependencies only. |
@antonymilne Sorry I mean to say pluggy but yeah the pin was removed. Before the new pluggy release it was necessary to pin it as test dependencies as it breaks certain API that we mock |
Fixed by #3840 already |
Description
Kedro currently pins Pluggy to >=1.0,<1.4
#3574
which was pinned because it broke tests
#3552
This is currently preventing upgrade of pytest - as pytest 8.1 requires pluggy >=1.4,<2.0
Context
Steps to Reproduce
Expected Result
Actual Result
Your Environment
pip show kedro
orkedro -V
):python -V
):The text was updated successfully, but these errors were encountered: