Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obscure error when _describe() is not implemented properly #4031

Closed
noklam opened this issue Jul 25, 2024 · 0 comments
Closed

Obscure error when _describe() is not implemented properly #4031

noklam opened this issue Jul 25, 2024 · 0 comments
Assignees
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed

Comments

@noklam
Copy link
Contributor

noklam commented Jul 25, 2024

Description

Related #4024

Context

image


unused_dataset:
  type: demo_project.datasets.NokDataset
  # filepath: data/01_raw/companies.csv
class NokDataset(AbstractDataset):

    def _load(self):
        return 1

    def _save(self,data):
        ...

    def _describe(self):
        ...

Arguably I have a bad implementation here as _describe is not returning dict properly. It takes me a while to find out this is due to a bad dataset implementation as I was not printing a dataset but simply running kedro ipython. This would work prior 0.19.7 because _describe was never used.

The error message is not helpful as a combination of

  1. it doesn't tell me which dataset is causing the problem
  2. unexpected __repr__ call when I am not printing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
Archived in project
Development

No branches or pull requests

3 participants