Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace io with catalog in DataCatalog docstrings #4033

Closed
ElenaKhaustova opened this issue Jul 25, 2024 · 3 comments · Fixed by #4034
Closed

Replace io with catalog in DataCatalog docstrings #4033

ElenaKhaustova opened this issue Jul 25, 2024 · 3 comments · Fixed by #4034
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@ElenaKhaustova
Copy link
Contributor

Description

Relates to #4024

Context

Recently we updated docs and replaced io with catalog for clarity: https://github.com/kedro-org/kedro/pull/3924/files

The same should be done for DataCatalog docstrings for consistency and clarity. Currently, we use a mixture of two names: catalog:

kedro/kedro/io/data_catalog.py

Line 718 in 5e15044

>>> catalog = DataCatalog()
and io:

kedro/kedro/io/data_catalog.py

Line 572 in 5e15044

>>> io = DataCatalog(datasets={'cars': cars})

@ElenaKhaustova ElenaKhaustova added the Issue: Feature Request New feature or improvement to existing feature label Jul 25, 2024
@yury-fedotov
Copy link
Contributor

Can I try to take this one?

@yury-fedotov yury-fedotov mentioned this issue Jul 25, 2024
Merged
7 tasks
@yury-fedotov
Copy link
Contributor

Can I try to take this one?

See: #4034

@ElenaKhaustova
Copy link
Contributor Author

Can I try to take this one?

Absolutely!

@github-actions github-actions bot mentioned this issue Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace io by catalog in docstrings of DataCatalog yury-fedotov/kedro
2 participants
@yury-fedotov @ElenaKhaustova