-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich markup regression in 0.19.7 #4094
Comments
I've found that the logger object being used in testing has nothing in its
|
The original tests are not that useful because they are not testing the actual logger (root) that do the work. I removed the cache as I don't think it's useful and simply move it as an internal attribute ( The original function try to be generic but I think it is a bit over-complicated for things that no one is using. |
That seems like it works nicely! Works without Rich as expected too. I fixed that one linter error that was popping up too. |
Context
The regression happened in 0.19.7.
before 0.19.7:
In 0.19.7:
The text was updated successfully, but these errors were encountered: