Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsspec 2021.5.0 & compatibility with pytorch lightning >= 1.3.0 #790

Closed
martinsotir opened this issue Jun 16, 2021 · 2 comments
Closed

fsspec 2021.5.0 & compatibility with pytorch lightning >= 1.3.0 #790

martinsotir opened this issue Jun 16, 2021 · 2 comments
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@martinsotir
Copy link

Description

Pytorch Lightning requires fsspec 2021.5.0 which clashes with Kedro 's requirement of fsspec < 0.9.

Context

Pytorch Lightning is a popular training loop wrapper for Pytorch. I am using it in a data pipeline to train neural nets.
The latest major release, 1.3, includes many bug fixes. I think they added a constraint on the fsspec versions because of some bugs in previous versions (for instance: fsspec/filesystem_spec#591). (However this makes it difficult to keep up with compatible versions. It's not the first time that Lightning change the constraint on fsspec)/

Possible Alternatives

Downgrade to Lightning 1.2.10 with fsspec 0.8.7

@martinsotir martinsotir added the Issue: Feature Request New feature or improvement to existing feature label Jun 16, 2021
@ignacioparicio
Copy link
Contributor

Hi @martinsotir and thanks for bringing up your issue! This is on our radar, we recently discussed internally fsspec's change from SemVer to CalVer. I created a ticket for it, but please understand that these are very recent (<2 months) changes for a single external dependency, so it might not make it to the next Kedro release. In any event, someone from the team will come back to this issue once we upgrade fsspec.

@ignacioparicio
Copy link
Contributor

We have upgraded our fsspec requirement from fsspec>=0.5.1, <0.9 to fsspec>=2021.04, <2022.01 (the upper bound to be revised past that date). The change will come into effect with the next Kedro release, be it 0.17.5 or 0.18.0.

I'm closing this issue for now, but please shout if you want it reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
None yet
Development

No branches or pull requests

2 participants