Cool, coverage job is working. You can view an uploaded test report by navigating the artifacts tab. An example - https://3627-171933613-gh.circle-artifacts.com/0/home/circleci/project/implementation/coverage/index.html

@liamzebedee can we either get this to not break the build and merge in master (ideal) or close?

You can likely have this generating the coverage artifact without less-than-full coverage failing the test

"less-than-full coverage" that's a good way of saying it's broken 😂

solidity-coverage appears to be broken for the interface contracts. Might be something to do with the upgrade to 0.5.0 (#213).

There was a problem instrumenting ./coverageEnv/contracts/interfaces/IKeep.sol: TypeError: Cannot read property 'stop' of null

Closing this for now until there's a better idea 😢

@liamzebedee what specifically was breaking? you can force solidity-coverage to ignore specific files, e.g. interfaces

• IERC721 but that's because it's duplicated (we've also got OpenZep versions)
• IKeep
• IPriceOracle

Will re-open this, got a bit further just now with ignoring the files

.solcover.js

module.exports = {
    skipFiles: ['whatever here']
};

Yeah this is the current config I have:

module.exports = {
    skipFiles: ['interfaces/IKeep.sol','interfaces/IPriceOracle.sol','interfaces/IERC721.sol','interfaces/ITBTCSystem.sol','interfaces/KeepBridge.sol'],
    copyPackages: ['openzeppelin-solidity', 'bitcoin-spv'],
}

But now getting this error sc-forks/solidity-coverage#245 - for tomorrow.

We need to capture this in an issue rather than pull a PR into the sprint board. Incidentally that issue can explain reasoning, describe how we might make it accessible, how it would fit into any workflow, etc.

Simply having test coverage available isn't really useful unless we know how it fits in with the workflow.

I have it running on my local, but only when installing deps using yarn. Since solidity-coverage only has a Yarn lockfile, and not package-lock, it's likely there's a subdep that has changed.

In either case, running it on CircleCI, and now there's a bizarre error about Node fibers. This is taking too long, gonna park it here for now