Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Official documentation with mdBook #437

Merged
merged 4 commits into from
May 14, 2023

Conversation

dpinones
Copy link
Contributor

@dpinones dpinones commented May 5, 2023

Added a project with mdbook for documentation.
Preview here

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@phklive
Copy link
Contributor

phklive commented May 6, 2023

Should we focus on the english version or should we also add a spanish version ( the problem could be maintaining the spanish repo )

@dpinones dpinones marked this pull request as ready for review May 10, 2023 03:38
@glihm
Copy link
Contributor

glihm commented May 12, 2023

Even if all languages are not fully translated yet, we can merge this and release the english documentation (hiding other languages in the languages picker).

This will enable contributors to start writting docs, @drspacemn @phklive, do you agree guys?

Copy link
Contributor

@phklive phklive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phklive phklive merged commit ddbe69f into eigerco:main May 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants