HibpOffline.cpp: small simplification

keepassxreboot · Mar 27, 2019 · a7e5d06 · a7e5d06
1 parent 58c3938
commit a7e5d06
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/core/HibpOffline.cpp b/src/core/HibpOffline.cpp
@@ -35,15 +35,15 @@ namespace
 
     ParseResult parseHibpLine(QIODevice& input, QByteArray& sha1, std::size_t& numPwns)
     {
-        char hexSha1[SHA1_BYTES * 2];
-        const qint64 rc = input.read(&hexSha1[0], sizeof(hexSha1));
+        QByteArray hexSha1(SHA1_BYTES * 2, '\0');
+        const qint64 rc = input.read(hexSha1.data(), hexSha1.size());
         if (rc == 0) {
             return ParseResult::Eof;
-        } else if (rc != sizeof(hexSha1)) {
+        } else if (rc != hexSha1.size()) {
             return ParseResult::Error;
         }
 
-        sha1 = QByteArray::fromHex(QByteArray(&hexSha1[0], sizeof(hexSha1)));
+        sha1 = QByteArray::fromHex(hexSha1);
 
         char c;
         if (!input.getChar(&c) || c != ':') {