Database information / statistics panel [$50 awarded]

[denk-mal]

It would be nice to have an info panel/window with some infos about the opened database
like full database path, number of entries, last write access time, outdated passwords, number of non unique passwords, ...

KeePassXC - 2.3.3
Revision: 0a155d8

Libraries:

• Qt 5.9.5
• libgcrypt 1.8.1

Operating system: Ubuntu 17.10 (shown by KeePassXC but it is 18.04)
CPU architecture: x86_64
Kernel: linux 4.15.0-22-generic

Enabled extensions:

• Auto-Type
• Browser Integration
• Legacy Browser Integration (KeePassHTTP)
• SSH Agent
• YubiKey

[droidmonkey]

The last two are covered under #551. I'm not sure the value of the first three though.

[denk-mal]

I saw the issue #551 but my intend was not those special information. My intend is for a more general place to get Infos about the actual loaded database(s) so if I had two versions of a database (at diff. places, of course) I can seen some general infos about them (especially but not only the file path, the number of entries and the last write access/change date)

[torerobo]

The program is open source. Then someone make a separate branch. It is necessary (just necessary) function the number of records in the database.
Make the function "counter the number of records in the database."
The problem is that I'm working and synchronizing different databases, because of this I am making new entries to the old database.

The android counter implemented in the keepassdroid in keepass2 also has a counter, why is not there? Because of such little things, huge problems

[droidmonkey]

Show full path of database file in this view (#2114)

[rugk]

Ah okay, here it is. Searched for "statistics" and could not find it here. So some other ideas:

---

My initial question was:

• How many passwords do I even have in the database?

Unfortunately, I could not find an easy way to see this.

So maybe you can show this for all selected items? Or for all of the group.

Maybe in a status bar? But well… this is oldish, I know, so maybe in a extra "Statistics" menu entry?

There, (combined with #2477), you may also show some more stats like:

• as said, database entry count
• oldest/newest used/created/… password
• maximal/minimal use count (Usage statistic (use count) about passwords #2477)
• whatever else may be useful

[AboveMyPaygrade]

Greetings! I didn't want to duplicate a feature request, and this appeared to be in the ballpark. @rugk made a suggestion regarding stats, which seems pretty great. I was hoping for something similar, but maybe less sweeping in scope. Specifically, I was hoping for an extra column in the normal database view which would show the number of the entry.

Currently, the open database has columns for "Title", "Username", "Password", etc. I was hoping to add a column which would assign a numerical value for each entry, so that I could see, at a glance, which number entry I was looking at, in, say, a specific group. The quote below might cover it, but I wasn't sure.

as said, database entry count

If this is out of scope, I would be happy to open a separate issue.

Thank you for your work.

[droidmonkey]

@AboveMyPaygrade I am not sure I understand your request. What number are you wanting to display? The sequential number of the entry as added to the database? The UUID of the entry?

[AboveMyPaygrade]

In the image below (shamelessly taken from one of the PRs), there are multiple columns (Title, Username, etc.). I was hoping one could be added that would show a number. For example, in the image, Amazon would be (1), Apple would be (2), Dropbox would be (3), and so on.

[droidmonkey]

But why? What does that number correspond to? You can sort the entries by clicking the column headers.

[AboveMyPaygrade]

Preference, I guess? The number itself would correspond to the entry inside the folder group. It makes it easier for me to see at a glance how many entries are in a specific group. Essentially, I've been manually moving from Lastpass to keepassxc (it's easier to export from LP and import to XC, but it was probably time for me to manually review my LP entries and edit/prune as needed), and while LP has a count for the number of entries in each folder, XC doesn't. I felt it would be easier to see if I was missing something at a glance using numbers versus having to read and compare the entries in the folders within LP and XC, and maybe count them manually to make sure I didn't miss one.

It's certainly a minor thing; it may not really be worth the trouble to implement if others haven't been clamoring for it. Either way, I very much appreciate the consideration/quick responses.

[droidmonkey]

It would be better (and easier) to just report the number of entries in the group. This could be shown in the entry/group preview panel and when editing a group.

[AboveMyPaygrade]

I'm not entirely sure if that request is covered by this issue number, or would require a separate one, but your suggestion sounds great!

[torerobo]

Received (and receive) requests for "adding statistics function". Why are developers ignoring? Why???

Why none of the users can make a separate branch of an open source project with the function of statistics?

[rugk]

@torerobo If you are so keen for this feature, why don't you do? 🤔

[torerobo]

@torerobo If you are so keen for this feature, why don't you do?

Why don't you do my work in the Arctic Circle?

And yes, dozens of people are interested ...

[droidmonkey]

I am going to add a bounty to this PR so maybe it'll motivate someone to work on it.

https://www.bountysource.com/issues/59353244-database-information-statistics-panel

[rugk]

Okay, that's also a good idea, so @torerobo you can obviously also add (to that) bounty.

[droidmonkey]

That's a great idea. Especially if there are any expired passwords that should be highlighted the error color.

[wolframroesler]

Sounds good, two questions:

1. You say "the error color", is there one particular color to use? Is it guaranteed that it can be used as a foreground or background color?
2. "Number of expired passwords" gets highlighted if >0, and "unsaved changes" gets highlighted if "yes", ok. "Average password length" could be highlighted if less than 10. But any idea when to highlight "non-unique passwords" or "maximum password reuse"? A small amount of reuse should be tolerated. Maybe set a percentage limit, like highlight if > 10 %? Any better ideas?

[droidmonkey]

I like those thresholds you mentioned. Instead of an error color (which breaks easily with dark themes) we can use an error or warning icon similar to what I have setup in the edit entry widget when the passwords do not match. See this code:

keepassxc/src/gui/PasswordEdit.cpp

Lines 32 to 40 in c19703c

	const QIcon errorIcon = filePath()->icon("status", "dialog-error");
	m_errorAction = addAction(errorIcon, QLineEdit::TrailingPosition);
	m_errorAction->setVisible(false);
	m_errorAction->setToolTip(tr("Passwords do not match"));
	const QIcon correctIcon = filePath()->icon("actions", "dialog-ok");
	m_correctAction = addAction(correctIcon, QLineEdit::TrailingPosition);
	m_correctAction->setVisible(false);
	m_correctAction->setToolTip(tr("Passwords match so far"));

keepassxc/src/gui/PasswordEdit.cpp

Lines 95 to 115 in c19703c

	void PasswordEdit::updateStylesheet()
	{
	QString stylesheet("QLineEdit { background: %1; }");
	if (m_basePasswordEdit && !passwordsEqual()) {
	bool isCorrect = true;
	if (m_basePasswordEdit->text().startsWith(text())) {
	stylesheet = stylesheet.arg(CorrectSoFarColor.name());
	} else {
	stylesheet = stylesheet.arg(ErrorColor.name());
	isCorrect = false;
	}
	m_correctAction->setVisible(isCorrect);
	m_errorAction->setVisible(!isCorrect);
	} else {
	m_correctAction->setVisible(false);
	m_errorAction->setVisible(false);
	}
	setStyleSheet(stylesheet);
	}

[wolframroesler]

Tried the color and it really didn't look good, don't even want to think about theming issues (or cultures where red isn't associated with "problem"). The icon is a much better idea, look:

[wolframroesler]

Any opinions? Anything else to add?

[droidmonkey]

The only additional idea I have is to add a tooltip to the warning/error icon that explains WHY it is being shown. These should be translatable as well.

[phoerious]

If we are really using tables, then they should at least be aligned properly. Right now it has additional margins around the edges.

[rugk]

From my comment here as far as I can see one information is still missing: How many passwords do I have in my DB?

[wolframroesler]

@rugk as in "number of entries that have a non-empty password"?

[wolframroesler]

@phoerious could you elaborate? Could you mark in the screenshot where exactly the table is not aligned properly?

[droidmonkey]

@rugk there is a line for "number of unique passwords" and one for "number of entries"

[rugk]

Ahh, yeah, "number of entries" was what I've missed, sry.

[wolframroesler]

Tooltips added and pushed to #3546.

[OLLI-S]

@droidmonkey Sorry if this question is stupid:
I have KeePassXC 2.5.2 Portable in Windows but I have no idea how to get the database-settings dialog.
I don't see this in the "Database" menu and also not when I right-click the root entry in the tree...

[wolframroesler]

@OLLI-S Please open a new issue and submit a screen shot with the contents of the Database menu.

This is the development issue, and it's closed, so the people who can help you won't see what you've written here. (I only see it because I contributed to the issue, but I can't help you because I'm not on Windows.)

[OLLI-S]

Sorry, @wolframroesler I simply have overseen the entry in the Database menu.
Embarrassing for me, really very embarrassing

[perdittmann]

I like the statistics feature a lot.
What I would like even more would be the possibility to actually do something about the issues of which I am alerted.

"Number of short passwords: 6"
To change those six, I'll have to go though all 324 entries and check the password length?

Or is there an easier way ("Show me all entries with a short/weak/duplicate password") that I am missing?

[wolframroesler]

@perdittmann the next release will have the "Health Check" report that shows you in detail which entries have issues. You can double-click lines in the report to jump directly into the entry editor. Here's a preview:

[perdittmann]

Wow, that's great news! Exactly what I was looking for – now I am looking forward to the next release.
Thank you very much!