Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Implement Freedesktop.org Secret Storage spec server side API #2726

Merged
merged 2 commits into from
May 12, 2019

Commits on May 12, 2019

  1. Improve existing code prior to implementing FDO Secrets

    * DatabaseTabWidget::newDatabase returns the created DatabaseWidget
    * Emit DatabaseTabWidget::databaseOpened signal before a new tab is added
    * EntrySearcher can now search attribute values including custom ones
    * Add Group::applyGroupIconTo to set the group icon on the supplied entry
    * Implement desktop notifications through the system tray icon
    * Add DatabaseWidget::deleteEntries to delete a list of entries
    * Add Aes128 in SymmetricCipher::algorithmIvSize
    * Add DatabaseWidget::databaseReplaced signal
    * Add a helper class to override the message box's parent (prevent bugs)
    Aetf authored and droidmonkey committed May 12, 2019
    Configuration menu
    Copy the full SHA
    88bffa3 View commit details
    Browse the repository at this point in the history
  2. Add Freedesktop.org Secret Storage Spec Server Side API (Fix keepassx…

    …reboot#1403)
    
    This plugin implements the Secret Storage specification version 0.2.
    While running KeePassXC, it acts as a Secret Service server, registered
    on DBus, so clients like seahorse, python-secretstorage, or other
    implementations can connect and access the exposed database in KeePassXC.
    
    Squashed commits:
    
    - Initial code
    - Add SessionAdaptor and fix build
    - The skeletons for all dbus objects are in place
    - Implement collection creation and deletion
    - Emit collectionChanged signal
    - Implement app-wise settings page
    - Implement error message on GUI
    - Implement settings
    - Fix uuid to dbus path
    - Implement app level settings
    - Add freedesktop logo
    - Implement database settings page
    - Change database settings to a treeview
    - Move all settings read/write to one place
    - Rename SecretServiceOptionsPage to SettingsWidgetFdoSecrets
    - Fix selected group can not be saved if the user hasn't click on the item
    - Show selected group per database in app settings
    - Disable editing of various readonly widgets
    - Remove unused warning about non exposed database
    - Fix method signature on dbus adaptors
    - Fix type derived from DBusObject not recognized as QDBusContext
    - Resolve a few TODOs around error handling
    - Remove const when passing DBus exposed objects
    - Move dismiss to PromptBase
    - Implement per collection locking/unlocking
    - Fix const correctness on Item::setSecret
    - Implement SecretService::getSecrets
    - Rework the signal connections around collections.
    - Remove generateId from DBusObject
    - Per spec, use encoded label as DBus object path for collections
    - Fix some corner cases around collection name changes
    - Implement alias
    - Fix wrong alias dbus path
    - Implement encryption per spec
    - Cleanup SessionCipher
    - Implement searchItems for SecretService
    - Use Tools::uuidToHex
    - Implement Item attributes and delete
    - Implement createItem
    - Always check if the database is unlocked before perform any operation
    - Add missing ReadAlias/SetAlias on service
    - Reorganize and fix OpenSession always returning empty output
    - Overhaul error handling
    - Make sure default alias is always present
    - Remove collection aliases early in doDelete
    - Handles all content types, fix setProperties not working
    - Fix sometimes there is an extraneous leading zero when converting from MPI
    - Fix session encryption negotiation
    - Do not expose recycle bin
    - Protect against the methods not called from DBus
    - Also emit collectionChanged signal when lock state changes
    - Show notification when entry secret is requested
    - Add a README file
    - Actually close session when client disconnects
    - Gracefully return alternative label when collection is locked
    - Reorganize, rename secretservice to fdosecrets
    - Fix issues reported by clazy
    - Unify UI strings and fix icon
    - Implement a setting to skip confirmation when deleting entries from DBus
    - Remove some unused debugging log
    - Simply ignore errors when DBus context is not available. QtDBus won't set QDBusContext when deliver property get/set, and there is no way to get a QDBusMessage in property getter/setter.
    - Simplify GcryptMPI using std::unique_ptr and add unit test
    - Format code in fdosecrets
    - Move DBusReturnImpl to details namespace
    - Fix crash when locking a database: don't modify exposedGroup setting in customData when database is deleted
    - Make sure Collection::searchItems works, whether it's locked or not
    - Fix FdoSecrets::Collection becomes empty after a database reload
    - Fix crash when looping while modifying the list
    Aetf authored and droidmonkey committed May 12, 2019
    Configuration menu
    Copy the full SHA
    f25f2e0 View commit details
    Browse the repository at this point in the history