Skip to content
This repository has been archived by the owner on Sep 29, 2024. It is now read-only.

Do not recover data on known errors #21

Merged
merged 4 commits into from
Sep 7, 2018

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Sep 7, 2018

Was reconnecting after ack-ing e.g. algorithm mismatch errors. Shut down instead.

Return boolean in socketShouldChangeProtocol indicating whether
another protocol is available.
Not recoverable by default (e.g algorithm mismatch).
@keeshux keeshux added the bug Something isn't working label Sep 7, 2018
@keeshux keeshux added this to the 1.1.0 milestone Sep 7, 2018
@keeshux keeshux self-assigned this Sep 7, 2018
@keeshux keeshux merged commit 01f65b2 into master Sep 7, 2018
@keeshux keeshux deleted the do-not-recover-data-on-known-errors branch September 7, 2018 22:10
@keeshux keeshux restored the do-not-recover-data-on-known-errors branch September 7, 2018 22:12
@keeshux keeshux deleted the do-not-recover-data-on-known-errors branch September 7, 2018 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant