Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add support for accent color automatically? #13

Closed
Dhyfer1 opened this issue Jul 1, 2024 · 10 comments
Closed

Can you add support for accent color automatically? #13

Dhyfer1 opened this issue Jul 1, 2024 · 10 comments

Comments

@Dhyfer1
Copy link

Dhyfer1 commented Jul 1, 2024

Hi @keifufu 👋

I discovered your repo today and it looks cool, and from what I see cute-borders doesn't follow the accent color. I haven't tested it, but the repo doesn't say so, maybe because it doesn't have that feature?

If it doesn't have that feature, I would like cute-borders to be able to customize the border color of certain programs with the accent color.

That's all.

@keifufu
Copy link
Owner

keifufu commented Jul 1, 2024

I don't see a reason not to add this, however I am not currently working on this project. I might get around to it when I feel like it. Thank you for the suggestion!

@Dhyfer1
Copy link
Author

Dhyfer1 commented Jul 1, 2024

Ok. I hope you take the time to add this feature, I'm sure it would be easy for you.

Well, I will wait for the next version for this.

@Dhyfer1 Dhyfer1 changed the title Can you add support for accent color? Can you add support for accent color automatically? Jul 1, 2024
@AndreGoressi
Copy link

AndreGoressi commented Sep 6, 2024

I don't see a reason not to add this, however I am not currently working on this project. I might get around to it when I feel like it. Thank you for the suggestion!

//here is an example code how to add it
tauri-apps/tauri#5305 (comment)

@keifufu
Copy link
Owner

keifufu commented Sep 6, 2024

Thanks, will add this soon.

@AndreGoressi
Copy link

Thanks, will add this soon.

No Problem :)

@keifufu keifufu closed this as completed in a82430a Sep 6, 2024
@Dhyfer1
Copy link
Author

Dhyfer1 commented Sep 6, 2024

Hi dev.

Thanks for the update, it does what I asked for at the beginning, I like it a lot 😊

Btw, would it be possible, as a feature, to have cute-borders work in the file explorer context menu and customize the border width?

@keifufu
Copy link
Owner

keifufu commented Sep 6, 2024

I believe not, context menus likely work different than windows so there is not much I can do there.

As for the border width... I would have to draw them myself in my own "invisible" windows that follow the other windows around, which is a pain. I did experiment with it on the direct2d branch (#1) but have decided that was too much work, especially since I no longer use windows myself.

@Dhyfer1
Copy link
Author

Dhyfer1 commented Sep 6, 2024

About the context menu, it's fine, I understand, it doesn't matter.

But I would like to see a wider custom border, two and three pixels wide is what I would like to see. I hope you will take this feature into account

@keifufu
Copy link
Owner

keifufu commented Sep 6, 2024

As I've said, I will not implement it due to it being an entirely different process from just 1px borders (which are drawn by windows itself, and I just have to provide the color).

@Dhyfer1
Copy link
Author

Dhyfer1 commented Sep 6, 2024

Well, okay, thanks anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants