Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade approval for changes to Instance Groups #321

Open
preflightsiren opened this issue Jul 15, 2021 · 1 comment
Open

Upgrade approval for changes to Instance Groups #321

preflightsiren opened this issue Jul 15, 2021 · 1 comment

Comments

@preflightsiren
Copy link
Contributor

Feature request

When an InstanceGroup is modified, there should be an approval process that controls when the InstanceGroup change is triggered.

See Certificate-Manager for an example: https://cert-manager.io/docs/concepts/certificaterequest/#approval

strawman workflow:

  1. Change to InstanceGroup
  2. UpgradeRequest CR is created
  3. Upgrade operator marks UpgradeRequest Approved
  4. Instance Manager creates the Custom Resource (eg. Argo workflow or RollingUpgrade)
  5. Modification continues as currently exists
@preflightsiren
Copy link
Contributor Author

inspired by #320

@preflightsiren preflightsiren mentioned this issue Aug 23, 2021
Open
@preflightsiren preflightsiren mentioned this issue Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@preflightsiren