From c9b1688b484242320e91d74b2ed05dbda01cc941 Mon Sep 17 00:00:00 2001
From: Shri Javadekar <shrinandj@users.noreply.github.com>
Date: Sat, 28 Dec 2019 23:50:00 -0800
Subject: [PATCH] Generate Kubernetes events for spot instance prices. (#58)

Testing Done:

- Verified that events get logged at periodic intervals
- Verified that data in the event is correct
- Verified that existing unit tests pass

Refs #50
---
 cloud_provider/aws/aws_minion_manager.py      | 48 ++++++++++++++++++-
 cloud_provider/aws/aws_minion_manager_test.py |  2 +-
 2 files changed, 48 insertions(+), 2 deletions(-)

diff --git a/cloud_provider/aws/aws_minion_manager.py b/cloud_provider/aws/aws_minion_manager.py
index 973afb4..6c00f39 100644
--- a/cloud_provider/aws/aws_minion_manager.py
+++ b/cloud_provider/aws/aws_minion_manager.py
@@ -18,6 +18,7 @@
 from cloud_provider.aws.aws_bid_advisor import AWSBidAdvisor
 from cloud_provider.aws.price_info_reporter import AWSPriceReporter
 from kubernetes import client, config
+from kubernetes.client.rest import ApiException
 from ..base import MinionManagerBase
 from .asg_mm import AWSAutoscalinGroupMM, MINION_MANAGER_LABEL
 
@@ -44,6 +45,8 @@ def __init__(self, cluster_name, region, refresh_interval_seconds=300, **kwargs)
                                          profile_name=aws_profile)
         else:
             boto_session = boto3.Session(region_name=region)
+
+        self.incluster = kwargs.get("incluster", True)
         self._ac_client = boto_session.client('autoscaling')
         self._ec2_client = boto_session.client('ec2')
 
@@ -163,6 +166,41 @@ def _describe_launch_configuration():
                         asg.AutoScalingGroupName,
                         launch_config.LaunchConfigurationName, bid_info)
 
+    def log_k8s_event(self, asg_name, price="", useSpot=False):
+        msg_str = '{"apiVersion":"v1alpha1","spotPrice":' + price + ', "useSpot": ' + str(useSpot) + '}'
+        if not self.incluster:
+            logger.info(msg_str)
+            return
+
+        try:
+            config.load_incluster_config()
+            v1 = client.CoreV1Api()
+            event_timestamp = datetime.now(pytz.utc)
+            event_name = "spot-instance-update"
+            new_event = client.V1Event(
+                count=1,
+                first_timestamp=event_timestamp,
+                involved_object=client.V1ObjectReference(
+                    kind="SpotPriceInfo",
+                    name=asg_name,
+                ),
+                last_timestamp=event_timestamp,
+                metadata=client.V1ObjectMeta(
+                    generate_name=event_name,
+                ),
+                message=msg_str,
+                reason="SpotRecommendationGiven",
+                source=client.V1EventSource(
+                    component="minion-manager",
+                ),
+                type="Normal",
+            )
+
+            v1.create_namespaced_event(namespace="default", body=new_event)
+            logger.info("Spot price info event logged")
+        except Exception as e:
+            logger.info("Failed to log event: " + str(e))
+
     def update_needed(self, asg_meta):
         """ Checks if an ASG needs to be updated. """
         try:
@@ -171,16 +209,24 @@ def update_needed(self, asg_meta):
             if asg_tag == "no-spot":
                 if bid_info["type"] == "spot":
                     logger.info("ASG %s configured with on-demand but currently using spot. Update needed", asg_meta.get_name())
+                    # '{"apiVersion":"v1alpha1","spotPrice":bid_info["price"], "useSpot": true}'
+                    self.log_k8s_event(asg_meta.get_name(), bid_info.get("price", ""), True)
                     return True
                 elif bid_info["type"] == "on-demand":
                     logger.info("ASG %s configured with on-demand and currently using on-demand. No update needed", asg_meta.get_name())
+                    # '{"apiVersion":"v1alpha1","spotPrice":"", "useSpot": false}'
+                    self.log_k8s_event(asg_meta.get_name(), "", False)
                     return False
 
             # The asg_tag is "spot".
             if bid_info["type"] == "on-demand":
                 logger.info("ASG %s configured with spot but currently using on-demand. Update needed", asg_meta.get_name())
+                # '{"apiVersion":"v1alpha1","spotPrice":"", "useSpot": false}'
+                self.log_k8s_event(asg_meta.get_name(), "", True)
                 return True
-
+            else:
+                # Continue to use spot
+                self.log_k8s_event(asg_meta.get_name(), bid_info.get("price", ""), True)
             assert bid_info["type"] == "spot"
             if self.check_scaling_group_instances(asg_meta):
                 # Desired # of instances running. No updates needed.
diff --git a/cloud_provider/aws/aws_minion_manager_test.py b/cloud_provider/aws/aws_minion_manager_test.py
index e1e0d11..a46dcbc 100644
--- a/cloud_provider/aws/aws_minion_manager_test.py
+++ b/cloud_provider/aws/aws_minion_manager_test.py
@@ -98,7 +98,7 @@ def basic_setup_and_test(self, minion_manager_tag="use-spot", not_terminate=Fals
         some basic sanity tests before returning it.
         """
         self.create_mock_asgs(minion_manager_tag, not_terminate)
-        aws_mm = AWSMinionManager(self.cluster_name_id, "us-west-2", refresh_interval_seconds=50)
+        aws_mm = AWSMinionManager(self.cluster_name_id, "us-west-2", refresh_interval_seconds=50, incluster=False)
         assert len(aws_mm.get_asg_metas()) == 0, \
             "ASG Metadata already populated?"