This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
Missing associate public ip address #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if yes then send request with attribute, if no then do not send request with attribute
|
The fix itself is fine. Can we add a unit test for this in https://github.com/argoproj/k8s-minion-manager/blob/master/cloud_provider/aws/aws_minion_manager_test.py? |
|
Alright I will add a unit test |
|
Feel free to open a new PR if/when the test is added. Merging this for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the same issue as argoproj/argo-workflows#878
After many updates with kops the launch configuration still is set to default when it comes to IP address type.
When the IP Address Type is set to default on a launch configuration, the AssociatePublicIPAddress attribute does not exist on the response back from describe_launch_configurations. That causes an exception when minion-manager creates a new launch config and references the AssociatePublicIPAddress attribute. I am not sure if this is the best way to fix this bug but it does work.
Let me know what you think.