This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
Add check on ASG activities insufficient resource #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hit this code. Means already have spot instance can't provision longer then 3 mins. So check is any activity's StatusMessage got insufficient error message. If yes, change the launch type to on-demand. I didn't make any record on it. So on next check. It should auto change back to spot instance.
|
|
|
Thanks for doing this. This makes the minion-manager that much more robust! |
shrinandj
reviewed
Mar 25, 2019
|
Can you add details about "Testing Done" similar to: #21 |
|
Testing Done:
|
shrinandj
reviewed
Mar 26, 2019
shrinandj
reviewed
Mar 26, 2019
Sorry, some copy and paste error. And didn't test again after that.
shrinandj
reviewed
Mar 26, 2019
|
@shrinandj any other comment?? |
|
I'll merge and test this. Looks like currently, the master branch is broken because of #28. I'll have a fix out for that shortly. Thanks for your contributions @alantang888 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This want to solve #13
When hit this code.
Means already have spot instance can't provision longer then 3 mins.
So check is any activity's StatusMessage got insufficient error message.
If yes, change the launch type to on-demand.
I didn't make any record on it.
So on next check. It should auto change back to spot instance.
There are something didn't solve.
moto. They didn't implementdescribe_auto_scaling_groups. So no test case added.