This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
Generate Kubernetes events for spot instance prices. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing Done: - Verified that events get logged at periodic intervals - Verified that data in the event is correct - Verified that existing unit tests pass Refs keikoproj#50
shrinandj
force-pushed
the
shri/generate-k8s-events
branch
from
66d98cd
to
ce9a741
Compare
|
@shrinandj should we also have a flag for minion manager to only will post events |
|
The events should be posted everytime (when the minion-manager makes the
changes to the ASGs or not). In a separate commit, we should introduce the
flag (say --events-only or --dry-run) which will decide whether the changes
to the launch-config are actually done or not.
What do you think?
…On Fri, Dec 27, 2019 at 2:56 AM Venkata Gunapati ***@***.***> wrote:
@shrinandj <https://github.com/shrinandj> should we also have a flag for
minion manager to only will post events
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58?email_source=notifications&email_token=AAXRDV54WWJXQCROBVKA22TQ2X3RLA5CNFSM4J6H2QS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHXESTA#issuecomment-569264460>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXRDVZR4DSZL2MRF6D6QKTQ2X3RLANCNFSM4J6H2QSQ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing Done:
Refs #50