This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
environment variable for events namespace and bug fix #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinandj
reviewed
Feb 1, 2020
| @@ -169,6 +170,7 @@ def _describe_launch_configuration(): | |||
|
|
|||
| def log_k8s_event(self, asg_name, price="", useSpot=False): | |||
| msg_str = '{"apiVersion":"v1alpha1","spotPrice":"' + price + '", "useSpot": ' + str(useSpot).lower() + '}' | |||
| mm_namespace = os.getenv('MINION_MANAGER_NAMESPACE', 'default') | |||
shrinandj
reviewed
Feb 1, 2020
| @@ -685,7 +688,7 @@ def minion_manager_work(self): | |||
| self.update_scaling_group(asg_meta, new_bid_info) | |||
| continue | |||
|
|
|||
| # Update ASGs iff new bid is different from current bid. | |||
| # Update ASGs if new bid is different from current bid. | |||
There was a problem hiding this comment.
The iff here was intentional. iff was for "if and only if"
There was a problem hiding this comment.
got it, I reverted the change
shrinandj
approved these changes
Feb 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.