Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed exports sort, added imports #203

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Removed exports sort, added imports #203

merged 2 commits into from
Oct 22, 2020

Conversation

Xunnamius
Copy link
Contributor

Closes #197

@keithamus
Copy link
Owner

Looks good, but snapshot tests are failing. If you run npm t locally you can see them fail. If you need any assistance fixing them up @fisker can hopefully help!

@fisker
Copy link
Collaborator

fisker commented Oct 20, 2020

npm run update-snapshot should be able to fix it.

@Xunnamius
Copy link
Contributor Author

Xunnamius commented Oct 20, 2020 •
edited
Loading

Thanks, I'll take a look at this tonight

@Xunnamius
Copy link
Contributor Author

Fixed. I made the initial commit through the GitHub UI so I missed the commitlint pass. Let me know if I should amend the commit message

@keithamus keithamus merged commit 89be2c9 into keithamus:master Oct 22, 2020
@github-actions
Copy link

🎉 This PR is included in version 1.46.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leave conditional exports alone
3 participants
@Xunnamius @keithamus @fisker