Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pnpm #313

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

samsternatretool
Copy link
Contributor

@samsternatretool samsternatretool commented Mar 26, 2024

pnpm (https://pnpm.io/) is a popular package manager that has support for advanced configuration via package.json fields. This keeps those deep keys sorted.

@@ -258,3 +258,59 @@ test('badges', (t) => {
'Should sort `badges[]`',
)
})

test('pnpm', macro.sortObject, {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this test looks overly specific it's because I took a real world example from my own repository (nothing private here) and set the expectation of how we'd like it sorted.

@samsternatretool
Copy link
Contributor Author

@keithamus do you want me to delete that test?

Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I was mistaken about the validity of the test.

@keithamus keithamus merged commit af54e91 into keithamus:main Mar 26, 2024
4 checks passed
Copy link

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants