Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support --check flag #86

Merged
merged 6 commits into from
Dec 3, 2019
Merged

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Dec 2, 2019

Add a simple implantation of --check flag.

Notice: no tests added.

fixes: #67

@fisker fisker changed the title feat: --check flag feat: support --check flag Dec 2, 2019
Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍. Some tests for this would be great though!

@fisker
Copy link
Collaborator Author

fisker commented Dec 3, 2019

tests added, should be good enough for --check. maybe we can improve later

@keithamus keithamus merged commit c93f739 into keithamus:master Dec 3, 2019
@keithamus
Copy link
Owner

🎉 This PR is included in version 1.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fisker fisker deleted the check-flag branch December 3, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--lint / --check mode
2 participants